flow-development-collection icon indicating copy to clipboard operation
flow-development-collection copied to clipboard

TASK: Remove Cli `Response::setColorSupport`

Open mhsdesign opened this issue 1 year ago • 1 comments

Followup to https://github.com/neos/flow-development-collection/pull/3260 see https://github.com/neos/flow-development-collection/pull/3260#discussion_r1454980924

Upgrade instructions

Review instructions

Checklist

  • [ ] Code follows the PSR-2 coding style
  • [ ] Tests have been created, run and adjusted as needed
  • [ ] The PR is created against the lowest maintained branch
  • [ ] Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • [ ] Reviewer - The first section explains the change briefly for change-logs
  • [ ] Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

mhsdesign avatar Jan 17 '24 09:01 mhsdesign

@kitsunet this pr just arose because you wished for it in https://github.com/neos/flow-development-collection/pull/3260#discussion_r1454956669

We might consider deprecating this altogether and just auto detecting even.

but as this is in no way actually solving anything or making things better / cleaner, i would also be fine with closing this

mhsdesign avatar Mar 06 '24 07:03 mhsdesign

Closing this as we have better things to do than to bikeshed about one flag in an otherwise already rottening cli framework :D.

be careful what you wish for as i will indeed create such prs if asked: ^^

We might consider deprecating this altogether and just auto detecting even.

mhsdesign avatar Mar 29 '24 13:03 mhsdesign