flow-development-collection
flow-development-collection copied to clipboard
neos
TASK: Add type hints and minimal cleanup in configuration builder
This is a minimal cleanup to the object management classes. Adding type hints, using more modern language constructs, and introducing constants for the cryptic array keys in the ObjectManager configuration.
Checklist
- [ x] Code follows the PSR-2 coding style
- [ x] Tests have been created, run and adjusted as needed
- [x ] The PR is created against the lowest maintained branch
- [ ] Reviewer - PR Title is brief but complete and starts with
FEATURE|TASK|BUGFIX - [ ] Reviewer - The first section explains the change briefly for change-logs
- [ ] Reviewer - Breaking Changes are marked wit
!!!and have upgrade-instructions
Mmm, how to deal with psalm here, it IS obviously correct that the calls could run into a null value, that hasn't changed though, I just clarified that with a type hint. Do I fake the type hint to be not null, seems like a bad idea as well... Neither do I want to null check the respective calls.
I haven't really compared but I will just close this in lieu of @mhsdesign stan changes which proably cover a bunch of these.
Hu well nice nice, i didnt know about this one ;) Will put some love into it to rebase it onto 9.0 ;)
Okay i had a little fun rebasing this ^^
Actually the most conflicts arose due to roberts proxy building refactoring 😅 like were your adjusted files have been removed: https://github.com/neos/flow-development-collection/pull/3064 But in all those cases i accepted the 9.0 part.
It still looks like that there are lots of valuable cleanups in the object manager in here which i was able to preserve ;)
For some reason i cannot get flow to boot. The changes in the configuration building seem to have killed it.
I stopped now after an hour but i would still suggest to take the usefull parts https://github.com/neos/flow-development-collection/pull/3308
Feel free to continue here or not :D