flow-development-collection icon indicating copy to clipboard operation
flow-development-collection copied to clipboard

Published 20 hours ago • verified publisher icon neos

TASK: Update psr/container requirement from ^1.0 to ^2.0

Open dependabot-preview[bot] opened this issue 3 years ago • 7 comments

Updates the requirements on psr/container to permit the latest version.

Release notes

Sourced from psr/container's releases.

2.0.0

Changed

  • This release adds the bool return typehint to Psr\Container\ContainerInterface::has(), in accordance with the PSR-11 type additions errata.
Commits
  • 68f5200 fix: alias master branch to 2.0.x
  • 122c267 Merge pull request #28 from weierophinney/feature/add-return-type-hints
  • 9fc7aab Merge pull request #20 from moufmouf/type_hinting
  • 381524e Merge pull request #27 from weierophinney/feature/add-param-hints
  • f9a9895 fix: update dev-master to 2.0.x-dev, not 3.0.x-dev
  • b1fbdff Merge pull request #29 from J0WI/patch-1
  • ccffa9f Update url to HTTPS
  • 2a09c4c fix: update branch alias to reflect 1.1 target
  • de1921e feat: add return type hints
  • 6c2bc7f feat: Adds parameter typehints to ContainerInterface
  • Additional commits viewable in compare view

dependabot-preview[bot] avatar Mar 08 '21 10:03 dependabot-preview[bot]

A newer version of psr/container exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

dependabot-preview[bot] avatar Mar 29 '21 12:03 dependabot-preview[bot]

Before bringing this to next majer, we need a corresponding issue, that we can link to the Flow 8 project board :)

sorenmalling avatar Nov 16 '21 14:11 sorenmalling

@mficzel we overlooked this one when updating the dependencies. Not sure we want to still get this into 8.0

albe avatar Apr 03 '22 14:04 albe

Should be fine. I am for doing this

mficzel avatar Apr 03 '22 14:04 mficzel

Now the only question is how to correctly avoid having $constructorArguments in the interface, but in our implementation, while keeping psalm happy.

albe avatar Apr 03 '22 15:04 albe

If we cannot do this properly we could remove the ContainerInterface from the object manager interface and create a psr 11 container instead that only implements psr11 and internally uses objectManager an configurationManager.

mficzel avatar Apr 03 '22 19:04 mficzel

Oh, come on Psalm… That is unrelated!

And now we (again) are at the point where a Behat update is needed. I'll look into that next week…

kdambekalns avatar Jul 07 '22 09:07 kdambekalns