Neos.NeosIo icon indicating copy to clipboard operation
Neos.NeosIo copied to clipboard

The component Neos.NeosIo:ButtonDimensionAware does not work

Open markusguenther opened this issue 5 years ago • 4 comments

On the page https://www.neos.io/docs-and-support/editor-documentation.html we are using Neos.NeosIo:ButtonDimensionAware to have a link to a page with another dimension, but sadly for the German link it is not working. The dimension url prefix is missing and the target is also not set.

Will check that out later.

markusguenther avatar Jun 26 '20 07:06 markusguenther

The issue is a result of this commit and I will look into the nodetype itself to solve that.

https://github.com/neos/Neos.NeosIo/commit/8dce847917c3f6015b03b850c99f055e5f1e77b8#diff-ce91c99e647d2d0e6076bea8946673b9

markusguenther avatar Jun 26 '20 09:06 markusguenther

Actually I hide the button because we also have the dimension menu that is working.

markusguenther avatar Jun 26 '20 11:06 markusguenther

Can we then just get rid of it?

Sebobo avatar Jun 26 '20 11:06 Sebobo

We also have the dimension menu so we can also remove it. The problem is by the way that the dimension is set with just one value ('de' in that case) but it needs to be the same like in values. So with dimensions: {language: ['de', 'en']} it works.

But did not continue after that.

markusguenther avatar Jun 26 '20 11:06 markusguenther