minreq icon indicating copy to clipboard operation
minreq copied to clipboard

Improve generic type parameters

Open alpha-tango-kilo opened this issue 2 years ago • 4 comments

Use AsRef<str> instead of Into<String> where sensible to do so Saves allocations and/or taking ownership Potentially a breaking change on some really weird types

alpha-tango-kilo avatar Jan 16 '22 21:01 alpha-tango-kilo

Rebased on latest master and resolved conflicts. Massively reduced the scope of the changes as there was no harm in using Into<String>/Into<URL> in a lot of places since an owned value was going to be needed anyway (like with all the Request::new aliases)

alpha-tango-kilo avatar Mar 18 '23 14:03 alpha-tango-kilo

CI failure looks to be #93

alpha-tango-kilo avatar Mar 18 '23 14:03 alpha-tango-kilo

It's been fixed now, rebasing onto the newest master should make the CI pass. The PR looks great!

neonmoe avatar Mar 18 '23 23:03 neonmoe

Thanks for the fix, all rebased!

alpha-tango-kilo avatar Mar 21 '23 22:03 alpha-tango-kilo