neon icon indicating copy to clipboard operation
neon copied to clipboard

Don't include unnecessary copies of final binaries in rust cache.

Open hlinnaka opened this issue 3 years ago • 2 comments

Should speed up the build, by reducing the amount of data that needs to be downloaded and re-uploaded on every build.

hlinnaka avatar Jul 29 '22 12:07 hlinnaka

After this PR:

Cache Size: ~1654 MB (1734568526 B) Before: Cache Size: ~3928 MB (4119229893 B)

I'm not sure if all the credit for that goes to this PR, I think simply purging the cache every now and then shrinks it too. But anyway, this is an easy win.

hlinnaka avatar Jul 29 '22 12:07 hlinnaka

After this PR:

Cache Size: ~1654 MB (1734568526 B) Before: Cache Size: ~3928 MB (4119229893 B)

I'm not sure if all the credit for that goes to this PR, I think simply purging the cache every now and then shrinks it too. But anyway, this is an easy win.

No, sorry, scratch that. I was comparing debug vs release builds, so that's nonsense. Comparing debug vs debug builds:

After this PR:

Cache Size: ~3916 MB (4106613371 B) Before: Cache Size: ~3928 MB (4119229893 B)

Which is quite disappointing. I think I got the glob patterns wrong, or the compression eliminates the duplicate binaries perfectly.

hlinnaka avatar Jul 29 '22 12:07 hlinnaka

As discussed moving to draft.

LizardWizzard avatar Mar 21 '23 15:03 LizardWizzard