neon icon indicating copy to clipboard operation
neon copied to clipboard

Remove daemonize dependency

Open bojanserafimov opened this issue 3 years ago • 5 comments

The library is not maintained anymore https://github.com/knsd/daemonize/issues/46

And there are other reasons to do daemonization differently, I'll let @funbringer elaborate (feel free to edit).

Originally posted by @funbringer in https://github.com/neondatabase/neon/pull/1834#issuecomment-1142398481

bojanserafimov avatar May 31 '22 18:05 bojanserafimov

+1 on modernizing this.

Would we still have a PID file, or is there a more modern alternative for that?

hlinnaka avatar May 31 '22 18:05 hlinnaka

JFYI on prod/staging we use systemd and do not pass --daemonize, so in theory we can remove this mode at all.

kelvich avatar May 31 '22 20:05 kelvich

Causing trouble again. Having quite a lot of unable to lock pid file. could not daemonize. bailing. errors here https://github.com/neondatabase/neon/runs/7690981632?check_suite_focus=true

LizardWizzard avatar Aug 05 '22 12:08 LizardWizzard

https://github.com/neondatabase/neon/runs/7786990204?check_suite_focus=true

failed on ci 3 times in a row

bojanserafimov avatar Aug 11 '22 12:08 bojanserafimov

Yeah, the failures are annoying and we need to fix them.

Let's track the failures, and fixing them one way or another, in https://github.com/neondatabase/neon/issues/2247. And keep this issue to track removing daemonize altogether.

hlinnaka avatar Aug 11 '22 12:08 hlinnaka