neon icon indicating copy to clipboard operation
neon copied to clipboard

pageserver: explore whether it's a good idea to replace `BlockBuf::blocks` with one big buffer.

Open yliang412 opened this issue 11 months ago • 1 comments

BlockBuf::blocks currently holds a list buffers. In the write path, we are writing them one block at a time. Since these blocks resides next to each other on disk, we could do a big disk write instead.

https://github.com/neondatabase/neon/blob/0066f23c656b54446f49f95b19bc13776597c9b6/pageserver/src/tenant/block_io.rs#L254-L259

DoD

Investigate whether it is a good idea to

  1. Replace BlockBuf::blocks with one big buffer, OR
  2. memcpy BlockBuf::blocks to the same buffer and do one big disk write.

Then implement if possible.

yliang412 avatar Dec 11 '24 15:12 yliang412

I'd like to help with this. Can you explain what exactly is needed? Does this issue need some additional arguments on what would be a better approach?

kiran-4444 avatar Jan 20 '25 18:01 kiran-4444

This issue was moved to Jira: LKB-2018

zenithdb-bot-dev[bot] avatar Jul 21 '25 11:07 zenithdb-bot-dev[bot]