Eli Black

Results 62 comments of Eli Black

Probably best to wait until https://github.com/microsoft/playwright-python/pull/2840 is merged, and then I can run checks locally.

@mxschmitt I'm still working on this, but I've split off a few simple and easy to review optimizations into https://github.com/microsoft/playwright-python/pull/2844

@mxschmitt While continuing to work on this, I've discovered something interesting. 1. In `_sync_base.py`, we set `__pw_stack__` and `__pw_stack_trace__` 2. In `_connection.py`, we check to see if the current task...

@mxschmitt Similarly, it might be nice to know if sending `apiName` and `internal` as part of the metadata is necessary or was just added because it was nice to have:...

I think that probably the best way to move this PR forward would be to modify the monkeypatch by @SichangHe (https://github.com/microsoft/playwright-python/issues/2744#issuecomment-2939291173), as it looks like it preserved the best of...

https://github.com/yarnpkg/berry/issues/5117 is a dupe of this.

What would `snapshotForAI` do?

Can you elaborate on "Since this is a user - defined key, it cannot be fixed as Semicolon because the user may input `'[].,....`"? Would `hotkey.replaceAll(';', 'Semicolon')` work?

@birdofpreyru Speaking hypothetically, do you think there would be any advantages to rewriting `react-helmet-async` to use the new built-in React features for head tags? I've been curious about this for...