neomjs
tab.Container: getLayoutConfig() => replace the switch block with an object (map)
This issue is stale because it has been open for 90 days with no activity.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello , I have added a pull request for it , Please review the changes and add a label for hacktoberfest2024
hi @TheCoderAdi!
the PR looks fine to me. I just took another look into the hacktoberfest rules, and if i understand them correctly, only PRs starting from October 1 count. If I am right on this one, you should re-send the PR on Tuesday, to ensure that you get the events credits.
Best regards, Tobias
Thank you for taking the time to review my PR! I really appreciate your feedback.
I'll hold off on any further pull/merge requests until October so they can count toward the event.
Looking forward to contributing once it starts!
Best regards, Aditya Swayamsiddha
On Sun, Sep 29, 2024, 4:41 PM Tobias Uhlig @.***> wrote:
hi @TheCoderAdi https://github.com/TheCoderAdi!
the PR looks fine to me. I just took another look into the hacktoberfest rules, and if i understand them correctly, only PRs starting from October 1 count. If I am right on this one, you should re-send the PR on Tuesday, to ensure that you get the events credits.
Best regards, Tobias
— Reply to this email directly, view it on GitHub https://github.com/neomjs/neo/issues/5429#issuecomment-2381315064, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2RBJLTSQUCOX4DNI2TFS7LZY7N4XAVCNFSM6AAAAABJWVH5HOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGMYTKMBWGQ . You are receiving this because you were mentioned.Message ID: @.***>
I hope you're doing well! Since Hacktoberfest has officially started, I wanted to kindly request if you could merge the pull request I recently submitted. This will allow the contribution to count towards the event, and I'd be thrilled to see it make a positive impact.
Thank you for your time and support!
This issue is stale because it has been open for 90 days with no activity.
This issue was closed because it has been inactive for 14 days since being marked as stale.