json-api icon indicating copy to clipboard operation
json-api copied to clipboard

Fix iterating over relationship data generator when generator is empty #252

Open lindyhopchris opened this issue 4 years ago • 0 comments

As described in the issue, if relationship data was an empty generator, an error would be triggered as the generator was iterated over twice when including related resources.

This is because the cache in RelationshipDataIsCollection was not being set to an empty array.

This PR adds two tests: one for a non-empty generator, and another for an empty generator. The empty generator test was failing before the single line fix was put into RelationshipDataIsCollection.

Closes #252

lindyhopchris avatar Feb 03 '21 16:02 lindyhopchris