nlp_profiler icon indicating copy to clipboard operation
nlp_profiler copied to clipboard

Add docker image

Open lilianabs opened this issue 1 year ago • 3 comments

To be able to merge a pull request, there are a few checks:

DO NOT DELETE THE BELOW TEXT FROM THE BODY OF THE PULL REQUEST. ADD YOUR DESCRIPTION(S) FROM THE POINT IT SAYS "Goal or purpose of the PR". USE THIS TEMPLATE AS IS.

USE THE CHECKLIST TO SHOW PROGRESS AND A REMINDER FOR YOURSELF.

Checklist

Please check the options that you have completed and strike-out the options that do not apply via this pull request:

  • [X] a clear title and description to the Pull Request has been provided
  • [X] you have read
  • [ ] the pull request passes the tests (./test-coverage.sh "tests slow-tests") - this will also be visible via the Code coverage report and CI/CD task on the Pull Request
  • [X] you have performed some kind of smoke test by running your changes in an isolated environment i.e. Docker container, Google Colab, Kaggle, etc...
  • [ ] the notebooks are updated (see notebooks folder, read the Notebooks docs)
  • [ ] CHANGELOG.md has been updated (please follow the existing format)

Goal or purpose of the PR

This PR adds a docker image for the package development.

lilianabs avatar Apr 02 '23 02:04 lilianabs

@lilianabs looks neat, nice work! I will test it out and share my comments here.

neomatrix369 avatar Jun 26 '23 21:06 neomatrix369

Could you pls post a screen shot of the docker container running and giving you a prompt as per the code - does not have to be exact or working, just want to see what it looks like on your end.

It's easy to take a screenshot and drag it into the comment box and it turns it into a image url to link to

neomatrix369 avatar Jun 26 '23 21:06 neomatrix369

Could you pls post a screen shot of the docker container running and giving you a prompt as per the code - does not have to be exact or working, just want to see what it looks like on your end.

It's easy to take a screenshot and drag it into the comment box and it turns it into a image url to link to

Thank you for reviewing the PR Mani! Here is a screenshot:

Screenshot 2023-06-26 at 20 01 48

lilianabs avatar Jun 27 '23 02:06 lilianabs