André Roth
André Roth
the handling of provided packages has been fixed on master, please try latest CI build !
See #1280
Continued in https://github.com/aptly-dev/aptly/pull/1074
Hi ! I implemented a queue, async tasks are now executed squentially in order, as soon as the required resources are avaiilable. could you give this a try ?
Aptly is now also using the queue for synchronous tasks. this should fix the concurrency problem completely. Could you test and confirm ? Thanks !
@refi64 could you have a look at https://github.com/aptly-dev/aptly/actions/runs/9429650201/job/25976276670?pr=1282#step:9:438 ? ``` PANIC: snapshot_test.go:26: SnapshotSuite.TestNewSnapshotFromRepository ... Panic: runtime error: invalid memory address or nil pointer dereference (PC=0x43D1FE) /opt/hostedtoolcache/go/1.21.10/x64/src/runtime/panic.go:914 in gopanic /opt/hostedtoolcache/go/1.21.10/x64/src/runtime/panic.go:261 in...
tests fixed, made compatible with go 1.19 (and current debian/bookworm)
I see your point. but crashing is also not an option, and if packageRefs is nil, then the number of packages in that repo is 0, so I think behavior...
Thanks for your excellent work ! I found another instance of accessing packageRefs without checking if it is nil and pushed a fix. Could you allow updating your [refi64:split-reflists](https://github.com/refi64/aptly/tree/split-reflists) branch...