jQuery-gridmanager icon indicating copy to clipboard operation
jQuery-gridmanager copied to clipboard

CSS independent button markup?

Open neokoenig opened this issue 9 years ago • 2 comments

I'm wondering whether it would make more sense to have the control bar markup have its own button CSS, rather than relying on bootstrap.

One of the issues is having to redo the config each time for foundation, so having a generic button class for the control bar which could then be overwritten in options might be good. Should only be a few lines of CSS I guess.

neokoenig avatar Jul 28 '14 10:07 neokoenig

Are you talking about: { controlButtonClass: "btn btn-xs btn-primary" } I assume?

Touching on my RTE comments, I'd also make this a config. That is, GM ships with two configs, one for Bootstrap and one for Foundation, which depending on the $(element).gridmanager({framework: 'bootstrap'}) property/value loads the required options for the specified framework at run time.

I'd make bootstrap the default.

This saves having to pass in a huge object for settings that related to Foundation vs Bootstrap and would create common grounds for people to start creating configs for other frameworks. The immediate benefit is that the Foundation folk wont hate on GM so much because they need to specify one massive settings object just to get off the ground, instead focusing on those options which are more framework-independent-like :)

userabuser avatar Jul 28 '14 10:07 userabuser

Agreed; it should probably be { framework: "bootstrap2|bootstrap3|foundation5|custom"; etc } and load sensible defaults. As you say, BS3 is going to be the main useage.

neokoenig avatar Jul 28 '14 10:07 neokoenig