Results 66 comments of Joel B

There was a draft PR here for a while too: https://github.com/TrenchBroom/TrenchBroom/pull/3932 I added some comments there about testing and trying to fix a few things. There are definitely a few...

FWIW I tried using this plugin on Amazon EKS (K8s version 1.13) and saw the exact same symptoms as above.

@kduske's original comment (mentioning "artificial") already implies this point, but just in case I'll add it here explicitly: func_group can be used intentionally in Q3 mapping (e.g terrain, lightmap scale,...

W.r.t. the group-stripping, it really does look like it would be handy to intervene at NodeSerializer::customLayer and NodeSerializer::group ... the question though is how to provide the NodeSerializer with state...

BTW any group/layer-stripping will unavoidably change the entity and brush numbering unless more complicated stuff is done (I think this is related to @kungfooman's original comment). I don't _think_ that...

Yeah, if you search for "brush %i" and "brush %d" in quake 1/2/3 compiler tools source, you'll get hits for various error messages. (Similar for entities.) e,g, in q3map2 >...

> I also think that we should not assign numbers to the layer and group entities so that the numbering is consistent between exported and regularly saved maps. Sounds reasonable,...

Actually, let me take a step back for a minute. For all the compilation-related uses of func_group that I mentioned, I don't have any evidence that other func_groups ("TB special"...

Since the work on "tool variables" is done, does issue #1924 cover the rest of this? Could close this issue and pursue the remaining stuff (builtin/default profiles) in that other...

As a possible interesting reference for this issue I'll attach my Quake 3 compile task configs. These correspond to the default compile tasks in netradiant-custom. As the file currently stands...