Implement synced registry check in holder stream codec

[Matyrobbrt]

Closes #839

[neoforged-pr-publishing[bot]]

• [x] Publish PR to GitHub Packages

Last commit published: 31fb8b8161229b4e6950855d43f5dc77375f9f39.

PR Publishing

The artifacts published by this PR:

• :package: net.neoforged:testframework:21.4.14-beta-pr-974-fix-839
• :package: net.neoforged:neoforge:21.4.14-beta-pr-974-fix-839

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #974' // https://github.com/neoforged/NeoForge/pull/974
        url 'https://prmaven.neoforged.net/NeoForge/pr974'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr974.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr974
cd NeoForge-pr974
curl -L https://prmaven.neoforged.net/NeoForge/pr974/net/neoforged/neoforge/21.4.14-beta-pr-974-fix-839/mdk-pr974.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[sciwhiz12]

@Matyrobbrt, do you still intend to update this PR to 1.21?

[Matyrobbrt]

Yes. ™

[embeddedt]

Is this still needed after 1.21.2?

[Technici4n]

Yes it is. @Matyrobbrt can you update this to 1.21.4 and apply pup's recommendation?

[neoforged-automation[bot]]

@Matyrobbrt, this pull request has conflicts, please resolve them for this PR to move forward.

[Technici4n]

Does Netty have a special check for CodecException, and your intention to make use of that? If not, better use a more standard Java exception IMO.

[Technici4n]

@XFactHD pointed out that vanilla already throws instances of CodecException (or rather: the derived Encoder/DecoderException) in that same class.

[neoforged-releases[bot]]

🚀 This PR has been released as NeoForge version 21.4.8-beta.