neoforged
Add more stones to the #c:stones tag
Currently #c:stones consists of:
"minecraft:andesite",
"minecraft:diorite",
"minecraft:granite",
"minecraft:stone",
"minecraft:deepslate",
"minecraft:tuff",
however, these don't encompass all stones in-game, or even just all overworld stones
I'm not entirely sure as to the use of this tag, but I assume that this (block and item) tag list is intended to contain all blocks that fit the following criteria:
- Pickaxe mineable block
- Intended to be "stone"-related
- Generates naturally in the overworld as part of terrain
In a custom modpack, I've seen the #c:stones tag used for the following:
- FTB Quests Quest Book
- Various Create recipes involving stone including Millstone and Crushing Wheels
The only mod I know that tags its custom stones as #c:stones is Regions Unexplored, meaning the #c:stones tag system is likely not understood by mod developers (for example Create doesn't tag it's Limestone as #c:stones, despite it generating in the overworld ground), this may be caused by the tag not even including the correct Vanilla content, so why would mods add to it?
Therefore the following blocks need to be added to the tag:
- Dripstone Block
- Calcite
- Sandstone
- Red Sandstone
- Prismarine (potentially, not actually found as a stone though)
- Smooth Basalt (potentially, it generates as part of geodes and in many worldgen mods/datapacks)
(mainly the first 4 are the most important to add)
It may also help to revise the whole system and make a c:stones/overworld, c:stones/nether, c:stones/end, and a c:stones (which encompasses the previous tags).
This is a case I encountered in the past, I never really knew what to make of the tag so ended up just using my own tags for more specific concepts I needed (granite, diorite, and alike in a tag directly). This tag clearly isn't meant to contain unnatural variants of the block (like stone bricks or polished), but also not including cobblestone I found weird.
My intuition is the tag was originally meant to cover blocks under the old stone registry ID before it was split; they all could replace stone in worldgen.
Some of the blocks you suggested to add feel a little weirder in the tag, such as sandstone which is notably softer. So perhaps the best way to move forwards is to suggest what the usecases of the tag are and try to meet those.
You mentioned Regions Unexplored, what do they use the tag for or is it just adding their blocks to it?
regions unexplored just adds all their stones (e.g chalk and argillite) to the tag
The javadoc for the tag says this:
It's basically the non-cobble counterpart to this vanilla tag:
https://github.com/misode/mcmeta/blob/data-json/data/minecraft/tags/item/stone_tool_materials.json
https://github.com/misode/mcmeta/blob/data-json/data/minecraft/tags/item/stone_crafting_materials.json
Knowing this, sandstone definitely does not belong in c:stones. Especially as we already got c:sandstone/blocks tag for that. Prismarine is more cobble-like and not interchangable anywhere in vanilla with stone stuff.
Only Calcite, Dripstone Block, and maybe Basalt could fit in the tag but the question becomes, will mods actually expect these blocks to be usable for crafting/repairing whatever stone tool or recipe they use c:stones for? Like they wouldn't expect Stone Bricks. More like raw stone materials.
cc: @cassiancc
Also, another thing to consider, everything in c:stones right now has a hardness of 1.5 or more. Calcite is very fragile of 0.75 and Basalt is 1.25 so they might be seen as too fragile to use as generic raw stone materials. Dripstone block is 1.5 so that one is fine there with hardness.
Looking at it now - the new "criteria" make sense to me. This should be for raw stone materials that generate during world generation. c:stones should not be used for repairing stone tools, as it does not include Cobblestone. Calcite, Dripstone, and Smooth Basalt should be added in my opinion. Ideally, I'd want c:stones, c:cobblestones, and c:sandstone to be more similar than they are now.
