Fix #2032 - Fixes issue where fluids sometimes do not affect boat passengers

Open MarcoSin42 opened this issue 8 months ago • 4 comments

Fixes #2032 by including a check on whether the entity's eyes are in lava in isInLava() and updating wasTouchingWater to match wasEyeInWater.

Apr 19 '25 13:04 MarcoSin42

[ ] Publish PR to GitHub Packages

Apr 19 '25 13:04 neoforged-pr-publishing[bot]

As an aside, I think getEyeInFluidType() should be renamed to getFluidTypeOnEyes() as the former sounds like it should take a fluid type as an argument and return a boolean.

Apr 19 '25 17:04 MarcoSin42

I do want to note (definitely not blocking imo, but something to consider) that not extinguishing fire in this case matches vanilla behaviour in 1.21.1 (and 1.21.2 and 1.21.4, but not 1.21.5), however silly that is. 2025-04-22_22 55 21

Apr 22 '25 21:04 VoidLeech

An addendum to this from my testing is that entities other than the player are extinguished when touching water.

Jul 12 '25 19:07 dhyces