NeoForge icon indicating copy to clipboard operation
NeoForge copied to clipboard

[1.21.x] Make RenderPlayerEvent subclass RenderLivingEvent

Open dhyces opened this issue 1 year ago • 4 comments

Closes #1266

Shouldn't introduce breaking changes other than binary breaks. Also took the opportunity to clean up some of the docs that referenced now removed features, like GenericEvents and HasResult, and renamed "Forge event bus" references to "game event bus".

dhyces avatar Jul 13 '24 18:07 dhyces

  • [ ] Publish PR to GitHub Packages

Putting a 1.21.1 tag on this PR. It is a bit too late now to move events around. We can revisit this PR on next breaking mc version. Or if you adjust this PR to only be javadoc cleanup, we can merge that and have an issue report or something to do the event moving in future mc version

TelepathicGrunt avatar Jul 24 '24 23:07 TelepathicGrunt

Understandable. I don't think the jdoc changes are important enough to warrant a separate PR just for these two classes. imo, they should either be fixed in bulk or modified when the classes are changed.

dhyces avatar Jul 24 '24 23:07 dhyces

@neoforged/bots run applyAllFormatting

Matyrobbrt avatar Nov 10 '24 15:11 Matyrobbrt

That's a very handy bot :p

dhyces avatar Nov 10 '24 15:11 dhyces

🚀 This PR has been released as NeoForge version 21.3.26-beta.

neoforged-releases[bot] avatar Nov 10 '24 16:11 neoforged-releases[bot]