NeoForge icon indicating copy to clipboard operation
NeoForge copied to clipboard

Namespace and Path switched in some RegisterGuiOverlaysEvent methods (1.20.2 to 1.20.4)

Open yurisuika opened this issue 1 year ago • 0 comments

Minecraft Version: 1.20.2 to 1.20.4

NeoForge Version: up to 20.4.237

Description of issue: I noticed that the versions of the methods that take in a string and attempt to create a ResourceLocation have the arguments swapped for some of the methods.

Correctly, some are new ResourceLocation(ModLoadingContext.get().getActiveNamespace(), id), but others are new ResourceLocation(id, ModLoadingContext.get().getActiveNamespace()), which would be like doing hunger_restored:appleskin instead of appleskin:hunger_restored.

I haven't checked 20.3, but I have noted this occurs in registerBelowAll in 20.2 and 20.4.

yurisuika avatar Jul 10 '24 06:07 yurisuika