MDK icon indicating copy to clipboard operation
MDK copied to clipboard

Use AFTER ordering for dependencies

Open FiniteReality opened this issue 1 year ago • 0 comments

Rationale: most hard dependencies do actually need to be loaded before their dependents.

It's likely the case that mods are copying the MDK's mods.toml and leaving the order as NONE for their dependencies, which can potentially cause crashes with "library mods", as their constructors have not been called before the dependent mods start trying to use them in their mod constructors. We should generally prefer AFTER as it is more likely to be correct for most mods, but keep the comment and explain that NONE should only really be used to avoid circular dependency load order issues.

FiniteReality avatar Jul 21 '24 00:07 FiniteReality