FancyModLoader icon indicating copy to clipboard operation
FancyModLoader copied to clipboard

Language provider errors are ignored

Open Gaming32 opened this issue 1 year ago • 0 comments

If a language provider isn't present, an errors list is created and passed to the sorter.

https://github.com/neoforged/FancyModLoader/blob/9b239e3414695ee2ab49ad6cc9aa96484db456de/loader/src/main/java/net/neoforged/fml/loading/moddiscovery/ModValidator.java#L99-L104

However, ModSorter.sort completely ignores its second argument, leading to missing language providers (modLoaders) simply skipping mods with no more than a logged error message. The language can't even be put into dependencies, because mods with erroring language providers get entirely removed from the mod list (before dependencies are checked).

Gaming32 avatar Feb 13 '24 22:02 Gaming32