FancyModLoader icon indicating copy to clipboard operation
FancyModLoader copied to clipboard

User agents for VersionCheck are missing information

Open LordRalex opened this issue 1 year ago • 0 comments

With the changes to Neo + FML, there is now much less information being sent into the User Agent. Notably, it is now missing the Minecraft version (previously included in the version itself) along with the actual implementation that is using FML. Accurately, the version it has provided is not even for FML, but for NeoForge. This means it is misleading.

Prior Example: Java-http-client/17.0.1 MinecraftForge/1.18.2-40.2.13 journeymap/5.9.7

Current: Java-http-client/17.0.9 FancyModLoader/47.1.47 extendedslabs/3.0.1

At the least it would be nice if "Minecraft/" was added to this User-Agent, so that it can be determined which version of the game is calling it.

Additionally, FML should not be the name, but it should be NeoForge instead.

Preferred: Java-http-client/17.0.1 NeoForge/47.1.47 Minecraft/1.20.4 journeymap/5.9.7

Acceptable: Java-http-client/17.0.1 NeoForge/1.20.4-47.1.47 journeymap/5.9.7

LordRalex avatar Dec 13 '23 17:12 LordRalex