FancyModLoader icon indicating copy to clipboard operation
FancyModLoader copied to clipboard

Default to AFTER ordering instead of NONE

Open FiniteReality opened this issue 1 year ago • 3 comments

Related to https://github.com/neoforged/MDK/issues/118

In most cases, a mod's dependencies DO actually need to be loaded before the mod in question is loaded - the current default of NONE means that our parallel construction can initialize a mod before its dependencies, leading to potential crashes due to thread timing nonsense. We should default to AFTER so that the typical use case is more likely to be correct, even if it does mean startup time is impacted slightly due to the strict ordering.

FiniteReality avatar Jul 21 '24 00:07 FiniteReality

I am against this change. Generally, there is no reason to reach for content of another mod within the same initialization phase.

Technici4n avatar Jul 21 '24 09:07 Technici4n

In most cases, a mod's dependencies DO actually need to be loaded before the mod in question is loaded

Can you please back that up with some data? A ton of mods depend on JEI/EMI/REI/WTHIT/Jade where that is not correct.

shartte avatar Jul 21 '24 10:07 shartte

Do you have examples of said crashes? I rather we simply teach people of the ordering and they can use it when it actually matters.

TelepathicGrunt avatar Jul 21 '24 11:07 TelepathicGrunt