ton4j icon indicating copy to clipboard operation
ton4j copied to clipboard

Refactor/anti melman

Open sidohin-felix opened this issue 1 year ago • 1 comments

sidohin-felix avatar Dec 16 '23 20:12 sidohin-felix

You can't just come to ton4j and then burger king.

You started to do the changes based on a very old version of ton4j (0.0.2) ~ 1.5y old. Since that time, I have also implemented a lot of changes, like TL-B support, HashMapAug and etc. It would be way better if you push smaller PRs, but more frequently. I don't like gradle, so don't try to replace maven. There is no point to remove smartcontract module it contains valuable smc interfaces. Class typing (TypedAsyncObject) is just another flavor and your way of doing it. Tonlib is already thread-safe. I took a few methods from your PR created by Vitaly Valtman.

I can't merge your PR with so many changes. I recommend you to keep your own version of ton4j and merge changes from official ton4j whenever you need them.

neodix42 avatar Mar 06 '24 16:03 neodix42