coc.nvim icon indicating copy to clipboard operation
coc.nvim copied to clipboard

feat(semanticTokens)!: token highlight groups

Open fannheyward opened this issue 2 years ago • 4 comments

BREAKING CHANGE:

  • CocSem + type to CocSem + Type + type
  • CocSem + modifier + type to CocSem + TypeMod + type + modifier
  • remove CocSem + modifier

The highlight group didn't need to be defined first.

  • [ ] semanticTokens.checkCurrent to the new highlight groups.

related #4659

fannheyward avatar Jun 05 '23 10:06 fannheyward

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.55%. Comparing base (1a8244e) to head (cb3d7be). Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4667      +/-   ##
==========================================
- Coverage   98.57%   98.55%   -0.03%     
==========================================
  Files         273      273              
  Lines       26077    26049      -28     
  Branches     5392     5385       -7     
==========================================
- Hits        25705    25672      -33     
- Misses        219      223       +4     
- Partials      153      154       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 05 '23 10:06 codecov[bot]

Isn't this creating multiple (about 2-4 times more) highlight spans on the same tokens in n/vim side?

And it does not fix the issue about priority in #4659.

oxalica avatar Jun 06 '23 19:06 oxalica

It's now working for me. We should also update history.md and doc/coc.txt for this breaking change.

oxalica avatar Jun 07 '23 11:06 oxalica

It's now working for me. We should also update history.md and doc/coc.txt for this breaking change.

And commit message? According to #4659 discussion, current commit/PR description is outdated.

oblitum avatar Jun 07 '23 13:06 oblitum

Needs rebase latest fixes and improve this.

fannheyward avatar Feb 21 '24 08:02 fannheyward

@oxalica merged to master, feedbacks are welcome.

fannheyward avatar Mar 20 '24 13:03 fannheyward