Incorrectly resolves root in monorepo

[joefiorini]

I have a monorepo with many package.json files throughout (managed with yarn workspaces). When I try to run :Jest or :JestCurrent it errors saying it can't find the Jest executable. In order to run it I have to first open my root level package.json.

It seems that the resolveRoot function uses findUp to find the nearest package.json and assumes that will be the location of Jest. Since I have multiple packages, it's most likely stopping too soon. Is there a reason not to use workspace.root from the coc.nvim plugin? I'm still new to this plugin and its ecosystem, but seems to be if something already has the root plugins should prefer that, no?

[Dammic]

I would also add myself to that question. It's a problem for yarn managed repositories. I would propose taking the workspace.root and adding a way to define our own independent files

[chemzqm]

It could be improved, consider send PR.

[IndexXuan]

any further ? please ~

[Geschoss]

@chemzqm hi! Can you give me permission to create PR I have PR with some stuff, like: -did some refactoring -using workspace.root as root dir -split logic in to different files

[IndexXuan]

@Geschoss you should

1. fork this repo in yours, as your coc-jest
2. clone it and do sth
3. git push your forked one
4. create pull request to origin coc-jest

[Geschoss]

@IndexXuan nice, thank you!

[Geschoss]

#9 need review=)

[Geschoss]

@IndexXuan can you check new version?

[IndexXuan]

@Geschoss I will local build your code and check it in my project tomorrow. while I am just user of coc-jest.