Tony Wasserka

The toolchain changes look good, but overall this gets a -1 from me due to the added build system->C++ source dependency in FEXLinuxTests. Using a regexp on a source file...

Any chance we could throw out the arch-specific defines and instead consolidate them to a single `FEX_HOST_ARCH` one? That allows us to reliably check for unhandled hostarchs in `#if-#elif-#else` cascades....

> How does that change the behaviour or chance of typo? Fair point - I was probably thinking that AARCH64/X86/RISCV are easier to correctly remember (or look up) than the...

I'm not convinced it's beneficial to rid of PackedArguments at the expense of moving more logic to the generator. The template is very lightweight, and my measurements indicated it doesn't...

FWIW https://github.com/FEX-Emu/FEX/pull/1868 adds a feature that makes the `_hostcall` symbols unnecessary and hence removes them entirely.

Once you're done fixing the remaining issues you mentioned, could you do a rebase pass over this to split the PR into more easily digestible patches for review?

# errno handling `errno` is a data symbol exported by `libc.so`, written to by many (but not all) libc functions on error (and written to by guest application to "reset"...

Agreed with @Sonicadvance1 's comment. Relatedly, see my comment from https://github.com/FEX-Emu/FEX/pull/1734: > > As mentioned in other channels, what I need to review your ThunkLibs PRs is better separation of...

Is it safe to assume the source was in range, or is this a shortcut taken as range-checking would be too expensive? (FTR, sadly neither this PR nor 2082 fix...

This affects `glX` functions outside the GLX 1.4 specification. In Mesa's non-GLVND `libGL.so`, these functions are defined as hidden symbols, which makes dlsym lookup fail in our host-side thunk library...