neo4j-core icon indicating copy to clipboard operation
neo4j-core copied to clipboard

Published 20 hours ago • verified publisher icon neo4jrb

Don't fail schema inspection when full text indexes exist

Open imustafin opened this issue 4 years ago • 9 comments

This pull introduces/changes:

  • Using Cypher queries instead of /db/data/schema/index endpoint for getting indexes and constraints in Neo4j >= 3.0.0 (since addition of the CALL clause)
  • Schema validation doesn't fail when full text indexes exist by ignoring such indexes

This PR is needed to allow using neo4j-core when full text indexes exist, without this PR schema validation fails as they appear as INDEX ON NODE:Label(key) instead of INDEX ON :Label(key) in db.indexes (more of the discussion: https://gitter.im/neo4jrb/neo4j?at=5e1efa848b53f6190ab79919).

This PR doesn't add any additional support for such indexes.

imustafin avatar Jan 22 '20 03:01 imustafin

Coverage Status

Coverage decreased (-3.7%) to 86.97% when pulling aada1715d51a24c04a22c74c51c785240385caa1 on imustafin:master into 4b649fca33a1b1dba8705e6f999764ad9fb4d76e on neo4jrb:master.

coveralls avatar Jan 22 '20 03:01 coveralls

Coverage Status

Coverage decreased (-4.3%) to 86.327% when pulling 3839629ef7dae7b930efc8c9c544ad86c3c30391 on imustafin:master into 4b649fca33a1b1dba8705e6f999764ad9fb4d76e on neo4jrb:master.

coveralls avatar Jan 22 '20 03:01 coveralls

Coverage Status

Coverage decreased (-4.3%) to 86.327% when pulling 3839629ef7dae7b930efc8c9c544ad86c3c30391 on imustafin:master into 4b649fca33a1b1dba8705e6f999764ad9fb4d76e on neo4jrb:master.

coveralls avatar Jan 22 '20 03:01 coveralls

I need help with jruby builds on Travis. I don't know how to fix them.

imustafin avatar Jan 22 '20 06:01 imustafin

@imustafin Can you make this PR against 10.0.x branch? That branch is going to be master soon. Thanks.

amitsuryavanshi avatar Jan 22 '20 09:01 amitsuryavanshi

@amitsuryavanshi I don't see the 10.0.x branch (https://github.com/neo4jrb/neo4j-core/branches/all). The newest branches I see are master and 9.0.x.

imustafin avatar Jan 22 '20 14:01 imustafin

@imustafin Pardon me, its for neo4jrb. Can you check neo4jrb 10.0.x branch if it is using neo4j-core. I assume its going to be removed from dependency. https://github.com/neo4jrb/neo4j/pull/1575/files

amitsuryavanshi avatar Jan 22 '20 14:01 amitsuryavanshi

@amitsuryavanshi I see that neo4j-core is moving to neo4j. I will make another PR to neo4j branch 10.0.x. What will happen to this PR to neo4j-core?

imustafin avatar Jan 22 '20 15:01 imustafin

@imustafin Let this be open. We yet to decide on what to do with neo4j-core.

amitsuryavanshi avatar Jan 23 '20 06:01 amitsuryavanshi