neo4j-core
neo4j-core copied to clipboard
neo4jrb
Escape strings in RemoveClause
Currently in RemoveClause only symbols are escaped with backticks, meaning that using .remove will fail on labels with special characters. This can be encountered with a namespaced label name, such as MyModule::MyThing.
This just makes the switch process strings and symbols in the same block.
Coverage decreased (-3.8%) to 86.804% when pulling 26c98440b29a4c0330d318d592a76733c8b410aa on NickTaylor-:escape-string-values-in-remove-clause into 4b649fca33a1b1dba8705e6f999764ad9fb4d76e on neo4jrb:master.
Coverage decreased (-3.8%) to 86.804% when pulling 26c98440b29a4c0330d318d592a76733c8b410aa on NickTaylor-:escape-string-values-in-remove-clause into 4b649fca33a1b1dba8705e6f999764ad9fb4d76e on neo4jrb:master.
Coverage decreased (-3.8%) to 86.804% when pulling 26c98440b29a4c0330d318d592a76733c8b410aa on NickTaylor-:escape-string-values-in-remove-clause into 4b649fca33a1b1dba8705e6f999764ad9fb4d76e on neo4jrb:master.
So it seems like this broke a lot of the tests due to it having some expectations that the generated queries not be escaped. I want to make sure that this PR makes sense before I try and fix those, so if I can get a 👍 that this is a reasonable change, I'll go through with it.