activegraph icon indicating copy to clipboard operation
activegraph copied to clipboard

ENV-based login/pass/encryption set

Open EugeneIstomin opened this issue 3 years ago • 2 comments

This pull introduces/changes:

  • Add possibility to set login, password, encryption on/off for using migration in non-Rails projects

EugeneIstomin avatar Jan 11 '21 18:01 EugeneIstomin

Code Climate has analyzed commit aca9026e and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

View more on Code Climate.

codeclimate[bot] avatar Jan 11 '21 18:01 codeclimate[bot]

Thanks @EugeneIstomin . Have you considered extracting this https://github.com/neo4jrb/activegraph/blob/master/lib/active_graph/railtie.rb#L82-L85 out of railtie.rb? There are many configuration options. Creating an environment variable each time someone needs one of those options doesn't seem like a sustainable solution. It would be great to solve the problem for any possible configuration.

klobuczek avatar Jan 11 '21 18:01 klobuczek