helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Adds support for allowing overrides to liveness, readiness, and startup probes

Open ryanmcafee opened this issue 7 months ago • 0 comments

Adds support for allowing overrides to liveness, readiness, and startup probes

Preserves backward compatibility with existing consumers of Neo4J helm chart

Tested by performing dry run of helm chart on main branch vs this feature branch and performing diff of manifests to ensure defaulted values causes manifests to render same values.

Main branch:

helm template ./neo4j --debug --dry-run --set neo4j.name=test-neo4j-cluster --set volumes.data.mode=defaultStorageClass > neo4j-cluster-manifests-main-branch.yaml

Feature branch: helm template ./neo4j --debug --dry-run --set neo4j.name=test-neo4j-cluster --set volumes.data.mode=defaultStorageClass > neo4j-cluster-manifests-with-updates.yaml

Then diffed the files.

Related Issue: https://github.com/neo4j/helm-charts/issues/337

neo4j_liveness_readiness_startup_probes_overrides_backwards_compatibility_diff_dryrun_debug_manifests

ryanmcafee avatar Jul 11 '24 16:07 ryanmcafee