neodash Extract NeoDash auth module to an abstract interface to allow for different providers

Extract NeoDash auth module to an abstract interface to allow for different providers

Open alfredorubin96 opened this issue 1 year ago • 3 comments

Detaching the query and authentication logic to a new class

Jan 25 '24 14:01 alfredorubin96

Codecov Report

Attention: Patch coverage is 35.26786% with 145 lines in your changes are missing coverage. Please review.

Project coverage is 37.36%. Comparing base (19b7538) to head (e7d7d98). Report is 10 commits behind head on develop.

:exclamation: Current head e7d7d98 differs from pull request most recent head 4895d8b. Consider uploading reports for the commit 4895d8b to get more accurate results

Files	Patch %	Lines
src/dashboard/DashboardThunks.ts	11.11%	64 Missing :warning:
src/extensions/rbac/RBACUtils.ts	0.00%	24 Missing :warning:
src/connection/ConnectionModule.ts	18.75%	13 Missing :warning:
src/connection/neo4j/Neo4jConnectionModule.ts	31.25%	11 Missing :warning:
src/connection/neo4j/utils.ts	79.41%	7 Missing :warning:
...oard/sidebar/modal/DashboardSidebarAccessModal.tsx	22.22%	7 Missing :warning:
src/connection/neo4j/runCypherQuery.ts	14.28%	1 Missing and 5 partials :warning:
src/application/logging/LoggingThunk.ts	0.00%	5 Missing :warning:
src/extensions/forms/chart/NeoForm.tsx	0.00%	2 Missing :warning:
src/extensions/rbac/RBACManagementMenu.tsx	0.00%	2 Missing :warning:
... and 3 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #767      +/-   ##
===========================================
- Coverage    37.49%   37.36%   -0.14%     
===========================================
  Files          216      220       +4     
  Lines         9140     9274     +134     
  Branches      2703     2730      +27     
===========================================
+ Hits          3427     3465      +38     
- Misses        5654     5745      +91     
- Partials        59       64       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.