neo4j-labs
Fix build (and upgrade arrow)
@thief-sty Thanks for the PR, I will have a look at it towards the end of the week.
@thief-sty I did continue a bit on your changes. Fixing the current clippy warning about elided lifetimes, will bring you to the problem that the Error in the result type is too large. This is being addressed in tonic 0.14 by boxing the Status. However, arrow 56.0.0 depends on tonic 0.13, which does not include the change.
Unless you have a better proposal, I am fine with allowing the lint for the time being in server/main.rs:
#![allow(result_large_err)]
and removing that line once arrow upgraded to tonic 0.14.
The remaining error is a deprecation warning, which you can fix by:
fn try_from(descriptor: FlightDescriptor) -> Result<Self, Self::Error> {
match DescriptorType::try_from(descriptor.r#type) {
Err => Err(Status::invalid_argument(format!(
"unsupported descriptor type: {}",
descriptor.r#type
))),
Ok(DescriptorType::Cmd) => {
serde_json::from_slice::<Self>(&descriptor.cmd).map_err(from_json_error)
}
Ok(descriptor_type) => Err(Status::invalid_argument(format!(
"Expected command, got {descriptor_type:?}"
))),
}
}
After that, clippy should be happy with the PR.
