neo4j-helm icon indicating copy to clipboard operation
neo4j-helm copied to clipboard

Improve probe overrides

Open kutysam opened this issue 2 years ago • 0 comments

Summary of the problem

Values file

livenessProbe:
  initialDelaySeconds: 180
  periodSeconds: 10
  failureThreshold: 3
  timeoutSeconds: 2
  httpGet:
    path: /db/mydatabase/cluster/available
    port: 7474

Final Template generated

livenessProbe:
  failureThreshold: 3
  httpGet:
    path: /db/mydatabase/cluster/available
    port: 7474
  initialDelaySeconds: 180
  periodSeconds: 10
  tcpSocket:
    port: 7687
  timeoutSeconds: 2

If you realize, tcpSocket is not expected to be in as we are using httpGet check.

It's documented here:

  1. https://helm.sh/docs/chart_template_guide/values_files/#deleting-a-default-key
  2. https://github.com/helm/helm/issues/9136

Option 1 as documented, will be to set null to the values. but this can be very messy. (If there is a new addon or change, we have to set it as null too)

My suggestion is to have an override values file where we can state any liveness that we wish to override. This is backward compatible and there is no breaking change.

kutysam avatar Sep 09 '21 07:09 kutysam