proposals icon indicating copy to clipboard operation
proposals copied to clipboard

Authentication Scheme

Open erikzhang opened this issue 3 years ago • 8 comments

erikzhang avatar Mar 19 '21 08:03 erikzhang

Amazing path @erikzhang ! It was less than a month ago that @vncoelho and I got a discussion on the matter. Structure looks nice, it would be interesting to provide some example perhaps, with Alice and Bob, and maybe sone contextualization over existing OAuth 2. Neo can certainly be such pioneer, specially with oracle technology.

igormcoelho avatar Mar 22 '21 02:03 igormcoelho

Any comment? @neo-project/everyone

erikzhang avatar Apr 17 '21 09:04 erikzhang

Rename nonce to UUID?

chenzhitong avatar Apr 20 '21 08:04 chenzhitong

To prevent site A from using site B's QR code to trick you into logging in. We should add the website name to the Challenge payload. When you scan the code, you will be prompted with "You will be logged in to **** website". It's like having the website name in the SMS verification code.

chenzhitong avatar Apr 20 '21 09:04 chenzhitong

Do we need to add an expiration timestamp to the Challenge payload.

chenzhitong avatar Apr 20 '21 09:04 chenzhitong

To prevent site A from using site B's QR code to trick you into logging in. We should add the website name to the Challenge payload. When you scan the code, you will be prompted with "You will be logged in to **** website". It's like having the website name in the SMS verification code.

The challenge payload will also need to be signed by the website (or the attacking site can just modify it)

djnicholson avatar Apr 20 '21 19:04 djnicholson

Rename nonce to UUID?

It's not UUID. It is a one-time random number.

Do we need to add an expiration timestamp to the Challenge payload.

I don't think it's necessary.

erikzhang avatar Apr 21 '21 02:04 erikzhang

To prevent site A from using site B's QR code to trick you into logging in.

In QR mode, there is a callback field. The client should show the domain of the callback url to the user. And the user can verify whether the website they are logging in is the domain name.

erikzhang avatar Apr 21 '21 03:04 erikzhang