neo icon indicating copy to clipboard operation
neo copied to clipboard

[VM] rename vm catchable and uncatchable exceptions

Open Jim8y opened this issue 1 year ago • 2 comments

Description

This pr tries to improve the VM exception type and inforamtion, making it easier to understand the VM exception.

Fixes # https://github.com/neo-project/neo/issues/3536

Type of change

  • [ ] Optimization (the change is only an optimization)
  • [x] Style (the change is only a code style for better maintenance or standard purpose)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Test Configuration:

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

Jim8y avatar Oct 17 '24 15:10 Jim8y

@roman-khimov @shargon please take a look, this is what i want to do with the exception currently. It just make it clear what the exception are and enfoce an exception message. If you think it is good to go, i will finish this pr. I think nothing will be influenced.

Jim8y avatar Oct 17 '24 15:10 Jim8y

Well, need to udpate UT still~~~ UTs are affected since exception type are different

Jim8y avatar Oct 17 '24 16:10 Jim8y

@Jim8y please take a look that there are no any more left, and the most important, no changes in catchable exceptions

shargon avatar Nov 07 '24 09:11 shargon

Its hard to implement what i planed without change the exception name, maybe just keep it as it is.

Jim8y avatar Dec 17 '24 07:12 Jim8y