neo icon indicating copy to clipboard operation
neo copied to clipboard

Handle https://github.com/neo-project/neo/pull/3520

Open Hecate2 opened this issue 1 year ago • 2 comments

Description

Handles VwEAwkpKAfoHdwARwG8AnXcAbwAl9////xHAzwJwlAAAdwDBwG8AnXcAbwAl9////0U=

Type of change

  • [x] Optimization (the change is only an optimization)
  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

invoke script VwEAwkpKAfoHdwARwG8AnXcAbwAl9////xHAzwJwlAAAdwDBwG8AnXcAbwAl9////0U= Should finish in 0.4s when https://github.com/neo-project/neo/pull/3520 is merged.

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

Hecate2 avatar Oct 09 '24 07:10 Hecate2

We better just do #3517 solving this and many other potential problems.

roman-khimov avatar Oct 09 '24 07:10 roman-khimov

We better just do #3517 solving this and many other potential problems.

I agree. Yet we can still do more to avoid GC. I have changed my strategy in this PR. We can check every dropped compound item to avoid graph searches.

Hecate2 avatar Oct 09 '24 08:10 Hecate2

We are replacing existing one with neogo gc, thus this pr is no longer needed.

Jim8y avatar Dec 31 '24 08:12 Jim8y