[**Added**] Build `neo-cli` Docker Image
Description
Now anyone can build there docker image with our neo-cli
Change Log
- Adds
dockerimage toghcr.io - Added
Dockerfileto.neo/docker/neo-clipath - Added
githubaction workflow for building image - Added deletion of old
dockerimages to save space.
Example
https://github.com/cschuchardt88/neo/pkgs/container/neo-cli
docker pull ghcr.io/cschuchardt88/neo-cli:3.8.0
Test Image locally
docker run --rm -i -t ghcr.io/cschuchardt88/neo-cli:3.8.0 /bin/bash
Docker Desktop
Github
Type of change
- [ ] Optimization (the change is only an optimization)
- [ ] Style (the change is only a code style for better maintenance or standard purpose)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] This change requires a documentation update
How Has This Been Tested?
Locally
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any dependent changes have been merged and published in downstream modules
@vncoelho I changed the scope of this PR.
wow, it works with github account. But maybe someone should manage the price if the docker image grows big. @steven1227 need NGD to decide if they want it.
I believe the size is around 80mb-100mb compressed. The base image is around 30mb, and with neo-cli is extra 55mb.
I removed the dockerfile from src\Neo.CLI. We don't need this anymore. Only platform is x64 currently. Anything else is out of the scope of this PR.
The dockerfile there is used for test. If you remove you need to adjust the tests to the new one.
@vncoelho where at are these tests? I checked main.yml.
@vncoelho where at are these tests? I checked
main.yml.
Indeed it can be removed for now. But better to do in another PR, I am not sure who is currently using this.
@vncoelho
Reverted the deletion of the Dockerfile in src\Neo.CLI