neo icon indicating copy to clipboard operation
neo copied to clipboard

Use `internal` keyword for all future code.

Open cschuchardt88 opened this issue 1 year ago • 2 comments

There is a lot of problems with allowing the classes to be public. One example is, everything we have now in code. Yes, you can say this is for others to access our blockchain or that it is the sdk. However this should be separated from the core code. Reason for, we can make the changes that we need without affecting 3rd parties. Having a separate dedicated sdk just for 3rd parties to use with 3rd party features. Allowing all our current code to be internal and allow in the application we choose. This way people don't try to use our code and don't have to support something that was intended for internal use anyways.

@Jim8y @shargon @roman-khimov @superboyiii @AnnaShaleva @vncoelho

Up for discussion.

cschuchardt88 avatar May 24 '24 21:05 cschuchardt88

agree

Jim8y avatar May 24 '24 23:05 Jim8y

It's ok for me

shargon avatar May 26 '24 09:05 shargon

Its agreed.

cschuchardt88 avatar Sep 05 '24 17:09 cschuchardt88