neo icon indicating copy to clipboard operation
neo copied to clipboard

Unify StatesDumper and StorageDumper plugins

Open vncoelho opened this issue 1 year ago • 10 comments

These two plugins were created with very similar ideas. They can be merged into one with parameters or functions to guide its functionality.

It will also improve maintenance and organization.

vncoelho avatar May 23 '24 10:05 vncoelho

@superboyiii, can you confirm that? I believe that one of them was created by you, and the other by Igor and I.

vncoelho avatar May 23 '24 10:05 vncoelho

Makes sense. My only concern is compatibility here, we (and I suspect we're not alone) have some tooling that uses StorageDumper output.

roman-khimov avatar May 23 '24 11:05 roman-khimov

Good idea but plugins are already there, can merge into one, but keep the original.

Jim8y avatar May 23 '24 12:05 Jim8y

Makes sense. My only concern is compatibility here, we (and I suspect we're not alone) have some tooling that uses StorageDumper output.

This is the one we originally created. Glad to know you use it.

I would sure keep compatibility, maybe just the name of the plugin will change.

vncoelho avatar May 23 '24 13:05 vncoelho

We can configure what kind of output we want, but it's better to unify

shargon avatar May 23 '24 15:05 shargon

I can make a new one If needed, with the two combined. I would be rewriting it. Also would be more features and Unit tests, If needed.

cschuchardt88 avatar May 24 '24 14:05 cschuchardt88

let me do this with time, there is no rush in this task.

vncoelho avatar May 24 '24 15:05 vncoelho

I can make a new one If needed, with the two combined. I would be rewriting it. Also would be more features and Unit tests, If needed.

but I appreciate your initiative, @cschuchardt88

vncoelho avatar May 24 '24 15:05 vncoelho

I can make a new one If needed, with the two combined. I would be rewriting it. Also would be more features and Unit tests, If needed.

vitor started, should let vitor do it.

Jim8y avatar May 24 '24 16:05 Jim8y

I did not yet started and it may take time...aheuahuea

vncoelho avatar May 24 '24 16:05 vncoelho

@superboyiii @roman-khimov

I checked here with careful. Both plugins are the same. ahueaheuaea There are just some minor differences in the saving procedure of each of them.

Have you been using one of these plugins? If so, which of them?

vncoelho avatar May 26 '24 21:05 vncoelho

I updated the title from unify to remove duplicated. There is nothing to UNIFY from these two plugins.

I checked the history on neo-modules and also verified code here. I do not know why, in the past, @Ashuaidehao and @superboyiii pushed this new module instead of refactoring StateDumper. Since then, we have these two DUPLICATED code.

As @roman-khimov said he was using StorageDumper and I also verified its code is more compact than my previous StateDumper plugin. Thus, I kept StorageDumper

vncoelho avatar May 27 '24 11:05 vncoelho