neo icon indicating copy to clipboard operation
neo copied to clipboard
verified publisher icon neo-project

Neo v3.5.0 Checklist

Open superboyiii opened this issue 3 years ago • 12 comments

Now we're making the checklist of neo v3.5.0 for release preparation. We plan to release v3.5.0 at the end of September.

Mandatory issues

  • https://github.com/neo-project/neo/issues/1879
  • https://github.com/neo-project/neo/issues/2782
  • https://github.com/neo-project/neo-modules/issues/756
  • https://github.com/neo-project/neo/issues/2789
  • https://github.com/neo-project/neo-modules/issues/768

Mandatory PRs

  • https://github.com/neo-project/neo/pull/2756
  • https://github.com/neo-project/neo/pull/2784
  • https://github.com/neo-project/neo/pull/2807
  • https://github.com/neo-project/neo/pull/2810
  • https://github.com/neo-project/neo-node/pull/853
  • https://github.com/neo-project/neo-node/pull/848
  • https://github.com/neo-project/neo-modules/pull/737
  • https://github.com/neo-project/neo-modules/pull/747
  • https://github.com/neo-project/neo-modules/pull/752
  • https://github.com/neo-project/neo-modules/pull/757
  • https://github.com/neo-project/neo-devpack-dotnet/pull/758
  • https://github.com/neo-project/neo-devpack-dotnet/pull/756
  • https://github.com/neo-project/neo/pull/2773
  • https://github.com/neo-project/neo/pull/2764
  • https://github.com/neo-project/neo-modules/pull/762
  • https://github.com/neo-project/neo/pull/2812
  • https://github.com/neo-project/neo-modules/pull/763
  • https://github.com/neo-project/neo-modules/pull/765
  • https://github.com/neo-project/neo/pull/2569
  • https://github.com/neo-project/neo-modules/pull/769

@neo-project/core @neo-project/developers @neo-project/ngd-seattle

superboyiii avatar Sep 05 '22 03:09 superboyiii

It'd be nice to have some definitive answer on #2773 for this release. Not that it's critical, but it's a pretty simple change to me, so we should at least make some decision on it after three months in the queue (my vote would be for accepting it).

Also, we'll try to prepare patches for #1992 and #1991 (as was proposed in https://github.com/neo-project/neo/pull/2661#issuecomment-1207840274), those would be nice to have in 3.5.0.

Worth considering: #2789 (trivial to implement, adds some possibilities), #2764.

roman-khimov avatar Sep 09 '22 20:09 roman-khimov

How about neo-project/neo-modules#762 and #2812?

roman-khimov avatar Sep 19 '22 07:09 roman-khimov

How about neo-project/neo-modules#762 and #2812?

Added

superboyiii avatar Sep 19 '22 08:09 superboyiii

please add https://github.com/neo-project/neo-modules/pull/763

devhawk avatar Sep 19 '22 18:09 devhawk

please add neo-project/neo-modules#763

Done.

superboyiii avatar Sep 22 '22 06:09 superboyiii

Please add https://github.com/neo-project/neo-modules/pull/765

ZhangTao1596 avatar Sep 23 '22 07:09 ZhangTao1596

This pr https://github.com/neo-project/neo/pull/2569 has being there for one year, and it fixes the crash while file in use issue, is that possible to add this one as well?

To reproduce the issue, reinstall applicationlogs right after you start the console. I think @nicolegys has experienced this issue many times.

image

Jim8y avatar Sep 24 '22 16:09 Jim8y

This pr #2569 has being there for one year, and it fixes the crash while file in use issue, is that possible to add this one as well?

To reproduce the issue, reinstall applicationlogs right after you start the console. I think @nicolegys has experienced this issue many times.

image

Done

superboyiii avatar Sep 24 '22 16:09 superboyiii

Please add neo-project/neo-modules#765

Done

superboyiii avatar Sep 24 '22 16:09 superboyiii

any chance of adding https://github.com/neo-project/neo-modules/issues/768? It should be a pretty minor fix

devhawk avatar Oct 04 '22 23:10 devhawk

any chance of adding neo-project/neo-modules#768? It should be a pretty minor fix

Done

superboyiii avatar Oct 10 '22 06:10 superboyiii

Is there an updated target date for 3.5 release?

devhawk avatar Oct 13 '22 17:10 devhawk

Is there an updated target date for 3.5 release?

Too many PRs still can't be merged. We have to filter some of these to ensure 3.5 can be released. What do you think?

superboyiii avatar Oct 17 '22 02:10 superboyiii

Can we please include https://github.com/neo-project/neo-vm/pull/493

ixje avatar Oct 19 '22 13:10 ixje

Is there an updated target date for 3.5 release?

Too many PRs still can't be merged. We have to filter some of these to ensure 3.5 can be released. What do you think?

I'm on the road for campus tour so I'm not in a position to review current state. @shargon and @roman-khimov are likely in a better position to judge this

devhawk avatar Oct 20 '22 04:10 devhawk

For me Fix assert is an important one

shargon avatar Oct 20 '22 17:10 shargon

@superboyiii can we include https://github.com/neo-project/neo-devpack-dotnet/pull/770 in 3.5? It's a minor update to the debug info

devhawk avatar Nov 16 '22 22:11 devhawk

FYI, https://github.com/neo-project/neo-devpack-dotnet/pull/770 is ready to merge

devhawk avatar Nov 18 '22 19:11 devhawk

@neo-project/everyone https://github.com/neo-project/neo-node/releases/tag/v3.5.0

superboyiii avatar Dec 08 '22 02:12 superboyiii