neo-project
featured log
Pull Request Test Coverage Report for Build 2201495427
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 15.08%
| Totals | |
|---|---|
| Change from base Build 2186768199: | 0.0% |
| Covered Lines: | 107 |
| Relevant Lines: | 683 |
💛 - Coveralls
I don't like this style. It adds a lot of unnecessary newlines. And I don't like the icons either.
I don't like this style. It adds a lot of unnecessary newlines. And I don't like the icons either.
Icon can be removed easily. new lines can be avoided. Formatted log makes it easier to address what is happening.
I'd say I like console log on and console log off. But I still prefer the original whole line in the same color, which looks more intuitive.
@nicolegys can you test again, i could not repeat the problem, everything works well on my machine.
@nicolegys can you test again, i could not repeat the problem, everything works well on my machine.
@shargon Hey shargon, I am not sure what exactly is your concern with this pr, just answer the following two previously unaddressed questions:
Only one
Console.Write?
Updated into one line.
Now that it's all the same color, do we still need to parse the message?
Indeed we still need to parse the message, it is a historic issue as the previous log has messages sticked together while we need to separate them apart.
I like
console log onandconsole log off. But I still prefer the original whole line in the same color, which looks more intuitive.
@erikzhang, your review is blocking. Can we proceed like this or you still want it to be off as standard?
@Liaojinghui, I think there should be some command to remove colors and keep original compatibility. Perhaps some people will prefer it clean as the original one.
@Liaojinghui, I think there should be some command to remove colors and keep original compatibility. Perhaps some people will prefer it clean as the original one.
It is already in the black/white mode for the most log, only errors will show in red and warning in yellow, the rest remains black/white
Tested again with long lines and works fine. Colors are just for warning and error and it is almost the same as default. Easier for futures control and modifications as well.