neo-node icon indicating copy to clipboard operation
neo-node copied to clipboard

Neo3 neo-gui: failed to vote.

Open nicolegys opened this issue 6 years ago • 10 comments

I tried to vote, but execution result was false. image

Here return false when checkwitness. image

Because cosigner is null. image

nicolegys avatar Dec 11 '19 09:12 nicolegys

We will improve neo-gui or create a new one?

shargon avatar Dec 11 '19 09:12 shargon

We will improve neo-gui or create a new one?

@shargon ,we are creating a new one.

longfeiWan9 avatar Dec 11 '19 10:12 longfeiWan9

@wanglongfei88 Then we should close this and mark neo-gui as obsolete

shargon avatar Dec 11 '19 12:12 shargon

@wanglongfei88 Then we should close this and mark neo-gui as obsolete

Let's keep this GUI before we finished the new one which will take some times since it is going to be a complete different tech stack.

longfeiWan9 avatar Dec 16 '19 09:12 longfeiWan9

Then... we should select the cosigner that you want to use it, because now, cosigners are empty

shargon avatar Dec 16 '19 09:12 shargon

Then... we should select the cosigner that you want to use it, because now, cosigners are empty

So now we need to provide a place to select the cosigner in this gui?

nicolegys avatar Dec 16 '19 14:12 nicolegys

Yes, I think that the problem is that we need to select the cosigners, but maybe i am wrong

shargon avatar Dec 16 '19 14:12 shargon

Yes, I think that the problem is that we need to select the cosigners, but maybe i am wrong

This is a transaction sent by one sender which is signer. I do not understand why we need to select the consigner because there is no one cosign this tx with me.

BTW, I have checked the code. When validating a tx, witnesses is matching sender and consigners both. But when checking witness, witnesses is only matching consigners, exclude sender. The consequence is that a tx will pass tx validation but failed on execution.

Is it something you guys design for some purpose or a mistake ?

longfeiWan9 avatar Dec 17 '19 07:12 longfeiWan9

Could you provide me the raw transaction in order to test it?

shargon avatar Dec 17 '19 08:12 shargon

my vote tx

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": "00e2e0c25134823bd0d6cd9a76590ef6ab0a8698e0751d2b750046c323000000003e04130000000000161c200000005a2102f143562d6cc1fab960ce26994eb03b9ae1f6fcfb961b47d0061934ab2db4925b51c11434823bd0d6cd9a76590ef6ab0a8698e0751d2b7552c104766f74651415caa04214310670d5e5a398e147e0dbed98cf4368627d5b52014140a690d3df8684fa5c60a4b96ace1b018f023445bc64f10899fc61690ba4bbe2429187dcfc7848ae270ad60f8ac608174cb83305c0fd9e9d7b161b107a285bb6b7282102707de001b7ec1c3ec4c125b0f3a5ddfebf8cb1dbd1631bee877800aef0ddc1ae50680a906ad4"
}
{
    "jsonrpc": "2.0",
    "id": 1,
    "result": {
        "hash": "0x5e7c7b581ce61bd210edf6f3d490b7a07c92a43e957ff3f16d099d5a8e5a91b7",
        "size": 246,
        "version": 0,
        "nonce": 1371726050,
        "sender": "NQhcLXMUShK1EaK7DPd7Z4XMyucWZy2mpP",
        "sys_fee": "600000000",
        "net_fee": "1246270",
        "valid_until_block": 2104342,
        "attributes": [],
        "cosigners": [],
        "script": "IQLxQ1YtbMH6uWDOJplOsDua4fb8+5YbR9AGGTSrLbSSW1HBFDSCO9DWzZp2WQ72qwqGmOB1HSt1UsEEdm90ZRQVyqBCFDEGcNXlo5jhR+Db7ZjPQ2hifVtS",
        "witnesses": [
            {
                "invocation": "QKaQ09+GhPpcYKS5as4bAY8CNEW8ZPEImfxhaQuku+JCkYfc/HhIricK1g+KxggXTLgzBcD9np17FhsQeihbtrc=",
                "verification": "IQJwfeABt+wcPsTBJbDzpd3+v4yx29FjG+6HeACu8N3BrlBoCpBq1A=="
            }
        ],
        "blockhash": "0xac919a07bab819f9b72297e4cbcf9f0e6180d92e4022ea0272c26dd63bb7f202",
        "confirmations": 2,
        "blocktime": 1576579690919,
        "vmState": "HALT"
    }
}

nicolegys avatar Dec 17 '19 10:12 nicolegys

Old, if remains, please re-open

shargon avatar Dec 05 '23 13:12 shargon