neo-node icon indicating copy to clipboard operation
neo-node copied to clipboard

Join config.json and protocol.json

Open shargon opened this issue 5 years ago • 7 comments

What do you think about join this two configuration files in only one?

shargon avatar Dec 10 '19 14:12 shargon

I think only one is better. Other fields may be optional.

lock9 avatar Dec 11 '19 15:12 lock9

Agree. I do not see too much advantage of having two separate configuration files. One config will be a better option.

longfeiWan9 avatar Dec 17 '19 01:12 longfeiWan9

I am not fully sure, in fact, they are a little bit different in terms of concepts.

But one config with the field ProtocolConfiguration also looks reasonable. I am not sure. What @erikzhang thinks?

vncoelho avatar Jan 06 '20 18:01 vncoelho

But we have plugin configuration files too. How to join all of them?

erikzhang avatar Jan 07 '20 04:01 erikzhang

Plugins are optional, I prefer to keep them as now

shargon avatar Jan 07 '20 08:01 shargon

Then I think there is no reason to join the config.json and protocol.json.

erikzhang avatar Jan 07 '20 09:01 erikzhang

I think that I prefer not to join it right now as well, until we do not have a global state for configuration, which would be nice.

On the other hand, the idea @erikzhang gave of joining Plugin sounds great. If Plugins are loaded it also looks from the same file. Then, we could later create tools for managing this file.

vncoelho avatar Jan 07 '20 12:01 vncoelho

Old, if remains, please re-open

shargon avatar Dec 05 '23 13:12 shargon