neo-modules icon indicating copy to clipboard operation
neo-modules copied to clipboard

Missing `wsport` field of `getversion` RPC structure on RPC client side

Open AnnaShaleva opened this issue 2 years ago • 2 comments

Describe the bug https://github.com/neo-project/neo-modules/pull/859 removed WsPort property from RpcVersion class on the RPC client side. We need to get it back, because NeoGo RPC server still supports WS capability and NeoC# RPC client is capable of interacting with both C# and Go nodes. It's OK not to have this field on the NeoC# RPC server side since WS server was removed form the C# node.

Expected behavior NeoC# RPC client should be able to properly unmarshal wsport field of the response to getversion RPC call.

Platform:

  • Version: RpcClient v3.6.3

AnnaShaleva avatar Jan 10 '24 09:01 AnnaShaleva

Unless C# adds ws support, otherwise Wsport will not be add back.

Jim8y avatar Jan 10 '24 09:01 Jim8y

What's the behavior now? The client will fail unmarshaling the response? Same thing can happen with new client accessing old server, please be careful.

roman-khimov avatar Jan 10 '24 18:01 roman-khimov