neo-modules icon indicating copy to clipboard operation
neo-modules copied to clipboard

ApplicationLogs and RpcNep17Tracker should not depend on LevelDB

Open devhawk opened this issue 4 years ago • 6 comments

StateStore doesn't take a dependency on LevelDB, instead it loads an IStore instance from the NeoSystem instance:

public StateStore(StatePlugin system, string path)
{
    if (singleton != null) throw new InvalidOperationException(nameof(StateStore));
    this.system = system;
    this.store = StatePlugin.System.LoadStore(path);
    singleton = this;
    StatePlugin.System.ActorSystem.EventStream.Subscribe(Self, typeof(Blockchain.RelayResult));
    UpdateCurrentSnapshot();
}

Can we update ApplicationLogs and RpcNep17Tracker to work this way?

devhawk avatar Jul 22 '21 23:07 devhawk

@superboyiii @devhawk any news about this issue?

This makes it very challenging (not to say impossible) to use rocksdb.

gsmachado avatar Dec 06 '21 08:12 gsmachado

Either we come up with a config in the node level to specify which DB it should use, OR each plugin should have a config to change the DB.

gsmachado avatar Dec 06 '21 08:12 gsmachado

The new token tracker plugin works like state store. So it's just app logs that still has this issue

devhawk avatar Dec 06 '21 16:12 devhawk

is this still an issue? gosh.....

gsmachado avatar Oct 26 '22 12:10 gsmachado

So... should we close this one?

Reference: https://github.com/neo-project/neo-modules/pull/761

gsmachado avatar Oct 26 '22 14:10 gsmachado

PR #807 depends on IStore, Hope this fixes issue.

cschuchardt88 avatar Nov 11 '23 15:11 cschuchardt88