neo-modules icon indicating copy to clipboard operation
neo-modules copied to clipboard

Move LogReader.BlockLogToJson / TxLogToJson to neo.dll

Open devhawk opened this issue 4 years ago • 2 comments

It would be nice for neo express to be able to reuse BlockLogToJson / TxLogToJson from ApplicationLogs plugin. However, express can't take a dependency on ApplicationLogs plugin w/o also taking a dependency on level DB. If we moved the ToJson methods to neo.dll, express could use them w/o the level db dependency

devhawk avatar Feb 02 '21 20:02 devhawk

Copy the code?

erikzhang avatar Feb 03 '21 04:02 erikzhang

Copy the code?

Harder to keep multiple copies of the same logic in sync.

devhawk avatar Feb 03 '21 17:02 devhawk