neo-modules
neo-modules copied to clipboard
neo-project
MultiSigInbox Plugin
Let's move on? I think it's useful although it's too late for RC1 but maybe we could implement it in RC2.
The plugin only could be used by white listed wallets, it's this ok?
I think it's enough.
@shargon
@superboyiii it's a argument parser issue, could you use "{ 'json with single quote' }"?
'json with single quote'
could you copy here your input as a text?
{"type":"Neo.Network.P2P.Payloads.Transaction","hex":"ALgo/ma0i5cAAAAAAKzjMwAAAAAA4hkAAAFsilPbqaK7CHEcRDMlSXnkU977vAEAWAsAZAwUzSoUqGD8JHFC\u002BkCpIXAF1Vus5dUMFGyKU9uporsIcRxEMyVJeeRT3vu8FMAfDAh0cmFuc2ZlcgwU9WPqQLwoPU0OBcSOowWz8qBzQO9BYn1bUjk=","items":{"0xbcfbde53e479492533441c7108bba2a9db538a6c":{"script":"EwwhAi/GL/XYE162iLZIO/ZV4Hqpy2og4wxdrfwJurDRI1UbDCEDZ\u002BCfDFJRx87OMc90EAM3pgj4T42FoVjyZ//EKjxYZxsMIQOoSJI0seBp53388sysHMFVPC1acgPH31ydUT8GIQmpyhNBe85spQ==","parameters":[{"type":"Signature"},{"type":"Signature"},{"type":"Signature"}],"signatures":{"022fc62ff5d8135eb688b6483bf655e07aa9cb6a20e30c5dadfc09bab0d123551b":"lK1ZGUWJYqAiCYdA2NZeyY7zAeUGtDze0nfaoQn//Z1djQk3FEv6oh7Ha5aRpj85/YYHBsrdN1jDzdcHKf4AuQ=="}}}}
Looks like it happened when write(witness) because incomplete context will not GetWitness().
Do we need this if we can have more generic Notary subsystem (neo-project/neo#1573)? This only works for a whitelist of addresses while Notary subsystem is available for anyone and can handle a lot more cases. It also adds another proper paid-for service for the network which can be beneficial for project economics. Notary subsystem has complete implementation in neo-go and it's already integrated into NeoFS (nspcc-dev/neofs-contract#51), it works.
@shargon inbox sign failed.
@superboyiii please copy your input as text here
neo> inbox list Transaction hashes 0x6cfe4b9371b075fbad4508b44c3b59fab48160d180195ce13bca82c6c3b98c02 0xdb2e8d4795b1b3bb966fc85ac2272660efe299e4a4763ebfc6e819f05dfdde1e 0x6b1baa343dd253c35d53017d20f62ea8a063f8ef9fd55457915c1b27de63ec56 0x0480f5fdbcce18ed77f69b0e33790d51eb7c2441f64986b807f50ab9d677eabf neo> inbox read 0x6cfe4b9371b075fbad4508b44c3b59fab48160d180195ce13bca82c6c3b98c02 {"type":"Neo.Network.P2P.Payloads.Transaction","hex":"AJApK2\u002B0i5cAAAAAAJwXdAAAAAAA7S4AAAH4JGXeIikja1DoxoxIKrkYu6bW7AEAWAsAZAwUXy/DPyeOyMAOrQfCSWlLdF\u002BI4E4MFPgkZd4iKSNrUOjGjEgquRi7ptbsFMAfDAh0cmFuc2ZlcgwU9WPqQLwoPU0OBcSOowWz8qBzQO9BYn1bUjk=","items":{}} neo> inbox sign 0x6cfe4b9371b075fbad4508b44c3b59fab48160d180195ce13bca82c6c3b98c02 error: One of the identified items was in an invalid format.
You could try it in my tempo testnet. https://github.com/superboyiii/neo-node/tree/RC1-CI01238
Maybe we could advance on this, could be a good feature besides Neo Committee that is now consolidated.
I still think this is a good plugin, @shargon.
Specific nodes can use it if they want. If it is optional I do not see a problem.
It's still too limited (hi, https://github.com/neo-project/neo-modules/pull/487#issuecomment-794406275), extensible messages can be sent by a very limited set of addresses.
