neo-devpack-dotnet icon indicating copy to clipboard operation
neo-devpack-dotnet copied to clipboard
verified publisher icon neo-project

Fix safe assert

Open shargon opened this issue 3 years ago • 1 comments

Alternative to https://github.com/neo-project/neo/pull/2783 Close https://github.com/neo-project/neo/issues/2782

shargon avatar Jun 30 '22 13:06 shargon

It feels like a better solution to this would be an ABORT with message opcode in NeoVM. Changing the behavior of assert depending on call flags seems sketchy

devhawk avatar Jul 08 '22 19:07 devhawk

https://github.com/neo-project/neo-devpack-dotnet/pull/790 this pr addresses the UT test issue

Jim8y avatar Sep 05 '23 07:09 Jim8y

#790 this pr addresses the UT test issue

I already fixed one by one xD, but thanks! it will be merged for future ones. Good fix!

shargon avatar Sep 05 '23 08:09 shargon

#790 this pr addresses the UT test issue

I already fixed one by one xD, but thanks! it will be merged for future ones. Good fix!

Its good as long as issues fixed

Jim8y avatar Sep 05 '23 08:09 Jim8y